Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events are dispatched in legacy mode #13

Closed
garak opened this issue Dec 6, 2021 · 1 comment · Fixed by #15
Closed

Events are dispatched in legacy mode #13

garak opened this issue Dec 6, 2021 · 1 comment · Fixed by #15

Comments

@garak
Copy link
Contributor

garak commented Dec 6, 2021

Events should be dispatched using the object as the first argument (and maybe the name as the second argument, for legacy compatibility).
The current implementation of dispatching names as the first argument is incompatible with modern libraries/frameworks.

I can provide a PR.
@eljam
Copy link
Owner

eljam commented Dec 7, 2021

Yes sure, would loved that :)

@garak garak mentioned this issue Dec 8, 2021
Merged
@eljam eljam closed this as completed in #15 Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix events garak/circuit-breaker
2 participants
@eljam @garak