Avoid the secret answer to be replaced by an empty string when changi…

…ng other fields in the account page leaving empty the secret question - fixes #2178

Signed-off-by: emanuele <emanuele45@gmail.com>

sources/subs/Profile.subs.php

@@ -805,6 +805,26 @@ function loadProfileFields($force_reload = false)
 			'value' => '',
 			'permission' => 'profile_identity',
 			'input_validate' => create_function('&$value', '
+				global $cur_profile;
+
+				if (empty($value))
+				{
+					require_once(SUBSDIR . \'/Members.subs.php\');
+					$member = getBasicMemberData($cur_profile[\'id_member\'], array(\'authentication\' => true));
+
+					// No previous answer was saved, so that\'s all good
+					if (empty($member[\'secret_answer\']))
+					{
+						return true;
+					}
+					// There is a previous secret answer to the secret question, so let\'s put it back in the db...
+					else
+					{
+						$value = $member[\'secret_answer\'];
+						// We have to tell the code is an error otherwise an empty value will go into the db
+						return false;
+					}
+				}
 				$value = $value != \'\' ? md5($value) : \'\';
 				return true;
 			'),