Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of undefined constant ... #1024

Closed
interlab opened this issue Nov 13, 2013 · 3 comments
Closed

Use of undefined constant ... #1024

interlab opened this issue Nov 13, 2013 · 3 comments
Labels
Milestone

Comments

@interlab
Copy link
Contributor

http://localhost/elkarte/install.php?step=5

Notice: Use of undefined constant BOARDDIR - assumed 'BOARDDIR' in C:\apache\php\localhost\www\elkarte\sources\Subs.php on line 3939

Notice: Use of undefined constant EXTDIR - assumed 'EXTDIR' in C:\apache\php\localhost\www\elkarte\sources\Subs.php on line 3939

Notice: Use of undefined constant LANGUAGEDIR - assumed 'LANGUAGEDIR' in C:\apache\php\localhost\www\elkarte\sources\Subs.php on line 3939

Notice: Use of undefined constant ADMINDIR - assumed 'ADMINDIR' in C:\apache\php\localhost\www\elkarte\sources\Subs.php on line 3939

Notice: Use of undefined constant CONTROLLERDIR - assumed 'CONTROLLERDIR' in C:\apache\php\localhost\www\elkarte\sources\Subs.php on line 3939

@AaronVanGeffen
Copy link
Contributor

I'm guessing this one is related to #1019

@emanuele45
Copy link
Contributor

I noticed it me too, this is because at step 5 it calls a hook, "in the past" the constants were used only if there was an hook, but during one of my previous commits I moved all the dirs to an array just at the beginning of the function and declared it as static.
I think we can define the constants the moment we have them during the install just to avoid another check in the hooks function.

@eurich
Copy link
Member

eurich commented Nov 13, 2013

It's probably related to function action_deleteInstall()
There are several require_once() but the CONSTANTS aren't defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants