Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upshrink header out from menu #1230

Closed
emanuele45 opened this issue Jan 9, 2014 · 6 comments
Closed

Upshrink header out from menu #1230

emanuele45 opened this issue Jan 9, 2014 · 6 comments
Milestone

Comments

@emanuele45
Copy link
Contributor

I think the expand/collapse icon doesn't fit at all in the menu, especially now that doesn't hide anything fundamental (like the search and the unread links it did in a previous life).

A nice way I've seen around is to have an "x" to just "close" something (it may be the header, it may be users' signatures for example) and keep the option to show them only in the profile page (look&layout).

@eurich
Copy link
Member

eurich commented Jan 10, 2014

yep, upshink is superfluous, Not sure if that X will be useful, will probably cause more support questions because people don't know how to get that hidden area back.

@emanuele45
Copy link
Contributor Author

A small demo, I'll push the code later.
The "x":
screen_179
screen_181
visible only on hovering the area.

The warning:
screen_180

Well, someone should rephrase it in case we will use that solution. 😛

@Spuds
Copy link
Contributor

Spuds commented Jan 10, 2014

Not to be a pain in the arse 😇 but how is this better that what we have? Granted the upshrink does not hide much, at least for us, but you can open/close it without moving to another page to find the option?

Don't be surprised If I'm missing something here since I've been looking at the upgrade script and now there is something wrong seriously with my brain.

@emanuele45
Copy link
Contributor Author

Well, first more code! 🍪

Then, on a side-effect, move the upshrink out of the menu that really doesn't make much sense.
Of course a simple upshrink out of the menu would work the same, but complicate things is so much fun!! 😛

@emanuele45
Copy link
Contributor Author

Other alternatives (well, the alignment is just a bit random :P).
On the left floated:
screen_182

On the right position: absolute
screen_183

@emanuele45 emanuele45 modified the milestones: 1.1 Beta, 1.0 Beta 2 Jun 15, 2014
@emanuele45 emanuele45 reopened this Jun 15, 2014
@emanuele45
Copy link
Contributor Author

Reopened assigning to 1.1

It may be a good idea to just remove the upshrink altogether.

@emanuele45 emanuele45 modified the milestones: 2.0, 1.1 Beta 1 Oct 21, 2015
@Spuds Spuds closed this as completed Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants