Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline Attachment .css missing #2201

Closed
wintstar opened this issue Sep 2, 2015 · 5 comments
Closed

Inline Attachment .css missing #2201

wintstar opened this issue Sep 2, 2015 · 5 comments

Comments

@wintstar
Copy link

wintstar commented Sep 2, 2015

Forum-Version: ElkArte 1.1
Aktuelle Version: 1.0.4 bug fix update

CSS instructions missing, see https://github.com/Spuds/Elk_Inline_Attachments/blob/1787d2bbd07909cb98d723b9229b40a481bfab0e/ILA.css. In Blue Feeling I inserted the CSS instructions. In the header of the style can be changed.

Look at here http://elkarte.scaricare.de/110/index.php?topic=3.0.

@emanuele45
Copy link
Contributor

Auch!
I guess I forgot to add it to the commit... LOL

@emanuele45
Copy link
Contributor

@Spuds I'm a bit lost, how did you do the align stuff in ILA? 😕
I can't see the parameters in the bbcode, did you do some other replacements somewhere?

@Spuds
Copy link
Contributor

Spuds commented Mar 13, 2016

Going from memory here so beware !

I thought the function ran post BBC so does not really depend on parseBBC :/

It searches for [attach= .........] and does its own parsing inside of the ila function itself. It should look for type, align and width parameters and set the class / replacement as needed. I think I had to do it that way to handle those friggin quote issues (since it does not render inside a quote, only links inside of a quote)

@emanuele45
Copy link
Contributor

Ohh... okay, makes sense.
Well, the new tag is using the bbc parsing and doesn't really have any option at the moment, so I guess we can move this to beta 2/3 waiting to add back what is missing. ;D

@emanuele45
Copy link
Contributor

At the moment, the img uses the same css of normal images embedded into the text.
It looks enough for now (until we have better handling at least), so I'm closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants