Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BeSocial numbers in menu misaligned in firefox #2483

Closed
emanuele45 opened this issue Apr 3, 2016 · 7 comments
Closed

BeSocial numbers in menu misaligned in firefox #2483

emanuele45 opened this issue Apr 3, 2016 · 7 comments

Comments

@emanuele45
Copy link
Contributor

I guess, as usual, a picture describes better the problem:
screen_448

Then numbers at the top are not... at the top, but below the menu entry.
Works fine in Chrome, seems broken in FF.

Also, are the dark borders intended?

@Vekseid
Copy link
Contributor

Vekseid commented Apr 3, 2016

Tag beta 3 - fixing some of this won't make much sense until I've got most/all of the icons done.

@Vekseid
Copy link
Contributor

Vekseid commented Apr 3, 2016

And the dark borders are because the color code was originally specified in the index.css file and not in _besocial or _light. It's defaulting to black accordingly.

@Spuds
Copy link
Contributor

Spuds commented Apr 25, 2016

I've fixed some of this for B1 ...

As things progress I'm sure it will need to be redone/updates again but I can't really see us having a B1 with this variant like this. It should be at least usable otherwise we just too much 💩

@Vekseid
Copy link
Contributor

Vekseid commented Apr 25, 2016

Best solution may be to diff them?

@Spuds
Copy link
Contributor

Spuds commented Apr 25, 2016

The main delta seems to be the border color, so 90% of the fix was simply setting it to be transparent in beSocial, and several menu indicators to display:none. Anyway not a lot of drama really, easy fixes

@Vekseid
Copy link
Contributor

Vekseid commented Apr 25, 2016

The entire idea behind doing this is to make making new color schemes easy. : )

@emanuele45
Copy link
Contributor Author

AFAICS this is no more valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants