Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jquery load #458

Closed
siddhartha-gupta opened this issue May 26, 2013 · 3 comments
Closed

Jquery load #458

siddhartha-gupta opened this issue May 26, 2013 · 3 comments
Milestone
1.0 Beta

Comments

@siddhartha-gupta
Copy link
Contributor

Just played with the code for a while and jquery wasn't working on my side. Not sure whether I missed something or what, but seems like a bug to me.

Found the settings variable was missing 'jquery_source', due to which 'template_javascript' in Subs.php is unable to load the JQuery file.

Moreover shouldn't there be a default case as well in the function, just in case.
@Spuds
Copy link
Contributor

Spuds commented May 26, 2013

That should be set to one of auto/local/cdn in the ACP ... if its blank it means we forgot to set it to a value in the install/upgrade scripts.

@siddhartha-gupta
Copy link
Contributor Author

Yup, its not initiated in the fresh installation for sure.

@emanuele45
Copy link
Contributor

Yep.
http://www.elkarte.net/index.php?topic=227.0
I thought it was fixed, but apparently we forgot... lol

@norv norv mentioned this issue May 27, 2013
Merged
@norv norv closed this as completed May 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0 Beta
Development

No branches or pull requests
4 participants
@norv @emanuele45 @Spuds @siddhartha-gupta