Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compact layout issue #548

Closed
norv opened this issue Jun 17, 2013 · 7 comments
Closed

Compact layout issue #548

norv opened this issue Jun 17, 2013 · 7 comments
Milestone

Comments

@norv
Copy link
Contributor

norv commented Jun 17, 2013

With

Don't show users' avatars.
Hide the poster information area.

both checked in profile, the layout of topic view is broken around poster area.

@StealthWombat
Copy link
Contributor

Yep, spotted that the other day. I was thinking it shouldn't be hard to fix.Just tweak it so the post runs full width and the poster name sits nicely with the keyinfo area. On the list.

@StealthWombat
Copy link
Contributor

Just a note: I think post/pm markup should be re-written slightly to get rid of some crud to do with margins on quickbuttons, etc. Related to this poster area swap thingy. We can end up with both simpler markup and simpler CSS (which I like).

@StealthWombat
Copy link
Contributor

Temp fix for this:
Find:

.poster span.name {
    display: block;
    padding: 6px;
    line-height: 1.5em;
    text-align: center;
    color: #46823c;
    font-size: 1.2em;
    font-weight: 600;
    overflow: hidden;
}

Add after:

/* @todo: Temp fix here. */
.poster.poster2 span.name {
    padding: 8px 8px 0 8px;
    font-size: 1em;
}

That gets the worst of it, but changes/re-write mentioned in previous comment will really clean it up.

@Spuds Spuds mentioned this issue Jun 19, 2013
@StealthWombat
Copy link
Contributor

Fixed. Close it. Have a parrot.

@StealthWombat
Copy link
Contributor

This one didn't need to be milestoned for beta. I fixed it a couple of weeks back. Code is already in the repo.

@norv norv closed this as completed Jul 15, 2013
@norv
Copy link
Contributor Author

norv commented Jul 15, 2013

Thanks! Closed then. It takes its place in the knocked-down issues milestoned for beta. :)

@StealthWombat
Copy link
Contributor

Oh well, in that case we should milestone all the closed issues to make it look like we really have our act together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants