Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memberlist Posts column data missing #620

Closed
Spuds opened this issue Jul 6, 2013 · 5 comments
Closed

Memberlist Posts column data missing #620

Spuds opened this issue Jul 6, 2013 · 5 comments

Comments

@Spuds
Copy link
Contributor

Spuds commented Jul 6, 2013

FF 22 ... When viewing the member list I get a white background blank box with a border under the post count column. I also have some custom fields enabled to show on the member list (just in case thats related or not)

@StealthWombat
Copy link
Contributor

Yeah I noticed that. It's probably related to me redefining a couple of things while knocking 91 divs off the stats template. The two templates share a little bit of code and I haven't got around to memberlist yet.

My 2c is that we drop the posts bar from the memberlist, and just have the numerical count. By the time people start enabling custom fields, the memberlist gets very crowded. I think the bars work well on the stats template, but have always thought they were a bit of a silly afterthough on memberlist, even without custom fields.

I've tried it on local with just the number of posts, and IMO it looks good. Saves code too. :)

@Spuds
Copy link
Contributor Author

Spuds commented Jul 7, 2013

Makes sense to me (numeric only) ... could also do it as a pie chart if we wanted a graphic that takes up less space.

@StealthWombat
Copy link
Contributor

TBH I'd rather not. Can't see the point of the extra code bloat required. Most of them will be zero, or close to it, on an established site. That means using a pie chart wont really tell you anything useful. The code require to run the thing would be a pita. We can cut a fair bit of crud by just going numerical, and put eye candy somewhere else if we want to.

@Spuds
Copy link
Contributor Author

Spuds commented Jul 7, 2013

But I like bloat, it helps me float in water and stuff ... pure numerical is fine by me, just offering up options should someone be hard over on a graphic.

@eurich eurich mentioned this issue Jul 7, 2013
@Spuds
Copy link
Contributor Author

Spuds commented Jul 10, 2013

addressed in #627 #621

@Spuds Spuds closed this as completed Jul 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants