Packages show as installed when they are not

[Spuds]

I don't want to wrap my head around this one ATM so I hope whoever did the refactor can recall a couple of things 😃

The basic issue is that the function isPackageInstalled will always return a named array, however the checks for "stuff" are all

isset(returned_data['somekey'])

which of course since the keys are set will pass, they are empty but set. I'm not sure the checks can be changed to empty() since 0 may be allowed (thats the part of me being lazy ATM and not wanting to wrap my head around it) ...

I guess one could also use null values in the default array and do a isnull check in place of isset.

OK please fix 😇

[eurich]

rofl, checked the logs... see 8019f69 ;)

[Spuds]

Doh! ... And I thought Ema and Ant were getting old 😆

Although in my defense that commit was fine 👯 it was a later one where I added 2 more items to the default array (to mask errors) from someone else's refactor (meaning I blame @norv ) ... OK I'm off to fix this before I have to eat another turd sandwich !

[emanuele45]

😱

We are all becoming too old for software development! 🍭

[Spuds]

Back to hell with this one !