Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated logo settings #20

Closed
Cam opened this issue Oct 29, 2017 · 3 comments
Closed

Duplicated logo settings #20

Cam opened this issue Oct 29, 2017 · 3 comments
Assignees
Milestone

Comments

@Cam
Copy link
Member

Cam commented Oct 29, 2017

We currently have duplicated settings for logos. This needs a cleanup, as does the way we define meta images like opengraph, favicon and itemprop sources.

It looks like "favorites_pinned_svg" isn't defined yet either.

I think this should take the form of settings for both a bitmap and svg image to be applied dynamically per use.

@Cam Cam self-assigned this Oct 29, 2017
@georgebutter georgebutter added this to the 2.0.2 milestone Oct 31, 2017
@georgebutter
Copy link

This sounds good! Do you have a recommend structure for the fav images I know there are supposed to be lots of different dimensions.

@oscarstranger
Copy link

oscarstranger commented Oct 31, 2017

@ButsAndCats this is a good guide for Favicons: https://github.com/joshbuchea/HEAD

As implemented in RC

@Cam
Copy link
Member Author

Cam commented Nov 1, 2017

+1 ...that's literally my go to

@georgebutter georgebutter mentioned this issue Nov 3, 2017
13 tasks
Cam pushed a commit that referenced this issue Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants