Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collection-product.liquid data-product-tags will close itself, if a tag contains a double quote #27

Closed
jibinycricket opened this issue Nov 17, 2017 · 2 comments
Assignees

Comments

@jibinycricket
Copy link

In snippets/collection-product.liquid, the data attribute "data-product-tags", closes itself if one of the tags contains a double quote.

I'm also really not sure what this attribute is being used for at the moment, along with data-product-id and data-product-price

@Cam
Copy link
Member

Cam commented Nov 19, 2017

Thanks @jmathew1991, I'll look into this. I'm about to do a round of overhauls.

The data product tags was used in a beta version for some rather fancy live filtering. I don't think we need it there for now. The live filtering will likely come back as an optional plugin later on.

@Cam Cam self-assigned this Nov 19, 2017
@georgebutter
Copy link

Removed.

Cam pushed a commit that referenced this issue Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants