Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate if optimizing the performance of the new resolve-implementation is necessary #29

Closed
elkowar opened this issue Oct 18, 2020 · 1 comment

Comments

@elkowar
Copy link
Owner

elkowar commented Oct 18, 2020

The resolve-implementation introduced in #26 is likely to bring significantly more overhead, as every value - even single, primitive values - are now handled as a List of possible VarRefs.
This could be optimized, at the cost of readability.

Acceptance criteria

  • A better understanding of the performance implications of the current implementation is gained
  • If concluded that optimizations would make sense, the code is thusly optimized implemented
@elkowar
Copy link
Owner Author

elkowar commented Nov 21, 2020

Given that there haven't been any noticable performance issues, this can be closed.

@elkowar elkowar closed this as completed Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant