Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve control functionality #52

Open
ellessenne opened this issue May 27, 2023 · 0 comments
Open

Improve control functionality #52

ellessenne opened this issue May 27, 2023 · 0 comments
Assignees
Milestone

Comments

@ellessenne
Copy link
Owner

I should re-implement the control logic, e.g., see the implementation of survival::coxph.control:

survival::coxph.control
#> function (eps = 1e-09, toler.chol = .Machine$double.eps^0.75, 
#>     iter.max = 20, toler.inf = sqrt(eps), outer.max = 10, timefix = TRUE) 
#> {
#>     if (iter.max < 0) 
#>         stop("Invalid value for iterations")
#>     if (eps <= 0) 
#>         stop("Invalid convergence criteria")
#>     if (eps <= toler.chol) 
#>         warning("For numerical accuracy, tolerance should be < eps")
#>     if (toler.inf <= 0) 
#>         stop("The inf.warn setting must be >0")
#>     if (!is.logical(timefix)) 
#>         stop("timefix must be TRUE or FALSE")
#>     list(eps = eps, toler.chol = toler.chol, iter.max = as.integer(iter.max), 
#>         toler.inf = toler.inf, outer.max = as.integer(outer.max), 
#>         timefix = timefix)
#> }
#> <bytecode: 0x7fda8182a3c8>
#> <environment: namespace:survival>

Created on 2023-05-27 with reprex v2.0.2

@ellessenne ellessenne self-assigned this May 27, 2023
@ellessenne ellessenne added this to the 0.13.0 milestone Aug 26, 2023
@ellessenne ellessenne removed this from the 0.13.0 milestone Dec 9, 2023
@ellessenne ellessenne added this to the 0.14.0 milestone Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant