Re-enable arm docker builds #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellie
approved these changes
Nov 17, 2022
ellie
added a commit
that referenced
this pull request
Feb 26, 2023
Docker builds are failing on ARM, let's see if they work on AMD. Might be worth waiting until we have less C that needs building This reverts commit f3894ef.
ellie
added a commit
that referenced
this pull request
Feb 26, 2023
rriski
added a commit
to rriski/atuin
that referenced
this pull request
Oct 2, 2023
This was previously enabled in atuinsh#616 and then reverted in atuinsh#730.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issues from the linked issue seemed to be closed, so I re-enabled arm docker builds to check.
The build succeeded, and you can find the packages here. I haven't had the chance to manually test it yet.
Closes #439