Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish: Fix atuin init for the fish shell #699

Merged
merged 1 commit into from Feb 14, 2023
Merged

Conversation

hunger
Copy link
Contributor

@hunger hunger commented Feb 7, 2023

When I try to do atuin init I get a error from fish, suggesting to replace $* with $argv.

This patch does that and makes fish accept with atuin init fish --disable-up-arrow. I did not do much testing after that though :-)

Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the catch! 🙏

@adamdicarlo0
Copy link

This works for me 👍🏻

@conradludgate conradludgate merged commit 7e7dd63 into atuinsh:main Feb 14, 2023
@hunger hunger deleted the fish_fix branch February 15, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants