add common prefixes and subcommands to stats #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
1 similar comment
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
conradludgate
force-pushed
the
03-09-add_common_prefixes_and_subcommands_to_stats
branch
from
3af4cc8
to
2580338
Compare
|
Aww squash commits make it a lil sad :( |
ellie
reviewed
Mar 13, 2023
| @@ -93,3 +91,75 @@ impl Cmd { | |||
| Ok(()) | |||
| } | |||
| } | |||
|
|
|||
| // TODO: make this configurable? | |||
There was a problem hiding this comment.
100%, though not blocking to merge this imo
ellie
approved these changes
Mar 13, 2023
conradludgate
deleted the
03-09-add_common_prefixes_and_subcommands_to_stats
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people wanted
sudoto be ignored, and then some commands likecargoandgitare so prevelant that the stat isn't interesting. This addresses both of those, although it's a little opinionated for now