update str substring usage to use range parameter
#840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I reported a related failure in #848 but close that in favor of this PR. |
ellie
approved these changes
Apr 5, 2023
|
Thank you for fixing this! Appreciate it 🙏 Seeing as this is your first time contributing, if you would like a holographic contributors-only Atuin sticker, then please fill out this form! https://notionforms.io/forms/contributors-stickers We have a Discord, if you're like to ask any questions! Or just hang out |
This was referenced Apr 6, 2023
Closed
|
if possible, could we get a point release including this ? |
yup - trying to get one out this weekend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, nushell's
str substringdoesn't accept string argument, I'd like to propose a update to use nushell range instead