Add some emacs movement keys #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ellie
approved these changes
Apr 9, 2023
There was a problem hiding this comment.
Thank you!
Seeing as this is your first time contributing, if you would like a holographic contributors-only Atuin sticker, then please fill out this form! https://notionforms.io/forms/contributors-stickers
We have a Discord, if you're like to ask any questions! Or just hang out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some common Emacs movement keys. Since Emacs mode is also the default for most shells the keys should be familiar to a lot of people. I kept accidentally adding
fs andbs to the search buffer when trying to jump around ...I also added an exception for a clippy lint caused by the additional match branches. It's not ideal but I'm not sure breaking up the function would be better.