Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Atuin stats with day, month, week and year filter #858

Merged
merged 4 commits into from
Apr 10, 2023
Merged

Atuin stats with day, month, week and year filter #858

merged 4 commits into from
Apr 10, 2023

Conversation

bahdotsh
Copy link
Contributor

@bahdotsh bahdotsh commented Apr 9, 2023 •
edited

Filter atuin stats with day, week, month and year filer by using atuin stats today, atuin stats week, atuin stats month, atuin stats year.

@vercel
Copy link

vercel bot commented Apr 9, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
atuin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2023 3:28pm

@bahdotsh bahdotsh marked this pull request as draft April 10, 2023 03:49
@bahdotsh bahdotsh marked this pull request as ready for review April 10, 2023 04:00
@bahdotsh bahdotsh changed the title Atuin stats with day, month and year filter Atuin stats with day, month, week and year filter Apr 10, 2023
ellie
ellie requested changes Apr 10, 2023
View reviewed changes
Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work! Just a few pointers and I think we're then good to go 😊

src/command/client/stats.rs Outdated Show resolved Hide resolved
src/command/client/stats.rs Outdated Show resolved Hide resolved
src/command/client/stats.rs Outdated Show resolved Hide resolved
src/command/client/stats.rs Outdated Show resolved Hide resolved
src/command/client/stats.rs Outdated Show resolved Hide resolved
@bahdotsh bahdotsh requested a review from ellie April 10, 2023 14:29
ellie
ellie previously approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ellie
Copy link
Member

ellie commented Apr 10, 2023

just a cargo fmt and we're good to go

@bahdotsh
Copy link
Contributor Author

Apologies for the back and forths for a simple PR!

@bahdotsh bahdotsh requested a review from ellie April 10, 2023 15:29
@ellie
Copy link
Member

ellie commented Apr 10, 2023

Not a problem! Thank you for the effort here 😊

@ellie ellie enabled auto-merge (squash) April 10, 2023 15:30
@ellie ellie merged commit e0c4ec5 into atuinsh:main Apr 10, 2023
8 checks passed
@chenrui333 chenrui333 mentioned this pull request Apr 16, 2023
Merged
@razvanazamfirei razvanazamfirei mentioned this pull request May 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellie ellie ellie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bahdotsh @ellie