-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workspace reorder #868
Workspace reorder #868
Conversation
Move main crate (atuin) to be on the same level with other crates in this workspace
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
possible panic sites are unchanged, they're just more visible now
993e60f this commit updates deps and fixes chrono deprecations. It added a bunch of unwraps, but in each case – previously the code would also panic in the same conditions, it's just more obvious now :) Aside from that – zero meaningful changes |
Thought I can annotate the diff, it that would be helpful, instead of noisy – just say if that'd help :) |
You can revert the last commit as we'll be going with #806 soon |
This reverts commit 993e60f.
Great! Reverted :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great - thank you!
Seeing as this is your first time contributing, if you would like a holographic contributors-only Atuin sticker, then please fill out this form!
Either way - thank you so much for the time and effort here ✨
atuin
) to be on the same level with other cratesAs a nice side-effect,
cargo test
/cargo nextest run
now runs tests from all the crates in a workspace, compared to the main crate only, as before :)What do you think?