Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace reorder #868

Merged
merged 5 commits into from
Apr 14, 2023
Merged

Workspace reorder #868

merged 5 commits into from
Apr 14, 2023

Conversation

utterstep
Copy link
Contributor

  • moved main crate (atuin) to be on the same level with other crates
  • extracted common deps to workspace definition, so it would be easier to avoid having same multiple dependencies with slightly different versions (base64 was an example)
  • slight fix to base64 usage, to comply with deprecation warning from v0.21

As a nice side-effect, cargo test/cargo nextest run now runs tests from all the crates in a workspace, compared to the main crate only, as before :)

What do you think?

@vercel
Copy link

vercel bot commented Apr 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
atuin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2023 11:11am

possible panic sites are unchanged, they're just more visible now
@utterstep
Copy link
Contributor Author

993e60f this commit updates deps and fixes chrono deprecations. It added a bunch of unwraps, but in each case – previously the code would also panic in the same conditions, it's just more obvious now :)

Aside from that – zero meaningful changes

@utterstep
Copy link
Contributor Author

Thought I can annotate the diff, it that would be helpful, instead of noisy – just say if that'd help :)

@conradludgate
Copy link
Collaborator

You can revert the last commit as we'll be going with #806 soon

@utterstep
Copy link
Contributor Author

You can revert the last commit as we'll be going with #806 soon

Great! Reverted :)

Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great - thank you!

Seeing as this is your first time contributing, if you would like a holographic contributors-only Atuin sticker, then please fill out this form!

Either way - thank you so much for the time and effort here ✨

@ellie ellie merged commit c05d285 into atuinsh:main Apr 14, 2023
8 checks passed
@utterstep utterstep deleted the workspace-reorder branch April 15, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants