Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-added package name to workspace.package #894

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

bdavj
Copy link
Contributor

@bdavj bdavj commented Apr 18, 2023

The package name was removed when cargo.toml was refactored to use workspace.package. This breaks the binary builds in actions, which depend on this key to generate a package name.

Re-add package name under workspace.package

@vercel
Copy link

vercel bot commented Apr 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
atuin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2023 3:57pm

@ellie
Copy link
Member

ellie commented Apr 18, 2023

Hey! Thanks for the contribution, but this has already been fixed in #885

The issue we have now is triggering the new workflow, but for an old release. Which requires the workflow rewriting to take a SHA/release as input to build for, from workflow_dispatch

@ellie ellie closed this Apr 18, 2023
@ellie ellie reopened this Apr 18, 2023
@ellie
Copy link
Member

ellie commented Apr 18, 2023

...although actually, on second thoughts, it probably would be sensible to add this anyway 🤔

Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! And sorry for the open/close 😂

If you fancy a contributors-only holographic sticker, then please fill out this form: https://notionforms.io/forms/contributors-stickers

Otherwise, do feel free to come hang out on our Discord! https://discord.gg/Fq8bJSKPHh

@ellie ellie enabled auto-merge (squash) April 18, 2023 20:29
@ellie ellie merged commit 281aa09 into atuinsh:main Apr 18, 2023
8 checks passed
@bdavj
Copy link
Contributor Author

bdavj commented Apr 18, 2023

Awesome, no worries at all - glad to have my name in something awesome I use all day everyday! (However small a commit :) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants