Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix key regression #974

Merged
merged 1 commit into from May 11, 2023
Merged

Fix key regression #974

merged 1 commit into from May 11, 2023

Conversation

ellie
Copy link
Member

@ellie ellie commented May 11, 2023

Keys saved with the old code would load with the new code. Keys saved with the new code would not load with the new code.

The old code didn't save a slice, but the new code does!

This tries both methods of loading, one of which will work. Some people will have been running main already, so it's too late to just break things

I'd still like to ditch msgpack tbh.

@ellie ellie requested a review from conradludgate May 11, 2023 20:08
@vercel
Copy link

vercel bot commented May 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
atuin ✅ Ready (Inspect) Visit Preview May 11, 2023 8:08pm

@ellie ellie marked this pull request as ready for review May 11, 2023 20:08
Copy link
Collaborator

@conradludgate conradludgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops 🤔 but yes let's ditch msgpack

@ellie ellie enabled auto-merge (squash) May 11, 2023 20:11
@ellie ellie merged commit b53ca35 into main May 11, 2023
9 checks passed
@ellie ellie deleted the ellie/fix-key-regression branch May 11, 2023 20:18
ealap pushed a commit to ealap/atuin that referenced this pull request May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants