Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes Vec allocation #1

Merged
merged 1 commit into from Sep 23, 2022

Conversation

pwoolcoc
Copy link

It looks like you are allocating a Vec and then immediately turning it back into an iterator, you can skip the allocation and just use the env::args iterator directly

@ramones156
Copy link

Looks like OP is relatively new to Rust. Not trying to discourage at all, I think this project could lead to something interesting!

As for another big sore thumb, you don't need to return true in your check_if_dir function, just return the condition

@elliot40404 elliot40404 merged commit b96fc6a into elliot40404:master Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants