Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

installation documentation #16

Closed
PaulSoderlind opened this issue Jul 4, 2020 · 2 comments
Closed

installation documentation #16

PaulSoderlind opened this issue Jul 4, 2020 · 2 comments

Comments

@PaulSoderlind
Copy link

Hi,
thanks for the package. It looks promising.

I believe the installation instructions

  1. should be changed to ] add git://GitHub.com/ellisvalentiner/AlphaVantage.jl (clone does not exist any more, or?
  2. say a word about what to do with the api key

Also, I tried fx_daily("EUR","USD",datatype="csv",outputsize="full") but it seems that outputsize is not defined in your function for daily FX rates.

/Paul Söderlind
@dm13450
Copy link
Collaborator

dm13450 commented Jul 4, 2020

Yeah it's currently on its way to the general registry, so on Monday you'll be able to add AlphaVantage like a normal package. I'll update the docs once its been accepted.

You are correct, I've just pushed a fix to correct this.

@dm13450 dm13450 closed this as completed Jul 4, 2020
@dm13450
Copy link
Collaborator

dm13450 commented Jul 4, 2020

And thanks for using the package and taking the time to report that bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dm13450 @PaulSoderlind