Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt canadaduane/typed-svg? #69

Closed
canadaduane opened this issue Apr 25, 2017 · 12 comments
Closed

Adopt canadaduane/typed-svg? #69

canadaduane opened this issue Apr 25, 2017 · 12 comments

Comments

@canadaduane
Copy link

canadaduane commented Apr 25, 2017

Leaving this here as a discussion point per Noah's request, so I can point interested parties here.

TypedSvg is an attempt to replace the elm-lang/svg package with a fully typed (and documented) equivalent. Some reasonable module separation has been included (for instance, to keep filters in their own modules, and my intent was to move animations to their own module as well). In addition, there are some convenience modules that help with common things like unit lengths (InPx, InEm) so that specifying the unit on every call is unnecessary.

I'd be happy if elm-community decided to adopt this, as I will be moving on from Elm.

https://github.com/canadaduane/typed-svg

@eeue56
Copy link
Contributor

eeue56 commented Apr 25, 2017

Needs someone to step forward as maintainer

@rupertlssmith
Copy link
Contributor

Happy to be the maintainer. I'll be using this library a lot in the coming months so I have an interest in looking after it. Also, many thanks to Duane for getting it this far.

@eeue56
Copy link
Contributor

eeue56 commented Apr 25, 2017

Are you familiar with how to publish a package?

@mgold
Copy link
Member

mgold commented Apr 25, 2017

In case you're not.

@rupertlssmith
Copy link
Contributor

Yes.

@avh4
Copy link
Member

avh4 commented Apr 25, 2017

FYI, I'd be happy to help review PRs for typed-svg (though wouldn't have time for active development).

@rupertlssmith, since you're stepping up, feel free to ping me if you ever need an extra hand.

@eeue56
Copy link
Contributor

eeue56 commented Apr 25, 2017

@rupertlssmith Please open a like this

@canadaduane Please transfer typed-svg to me. Thanks for your work on it, it's in good hands!

@canadaduane
Copy link
Author

Transferred. Thanks all!

@rupertlssmith
Copy link
Contributor

Hopefully, this is what you meant:

#70

@eeue56
Copy link
Contributor

eeue56 commented Apr 27, 2017

@canadaduane Please fork it back to your account -- right now, nobody can install typed-svg from you. That's my bad, I should've said. I'll make a checklist to make this easier in future.

@gampleman
Copy link

FYI, I'd be happy to help review PRs for typed-svg (though wouldn't have time for active development).

Same here.

@canadaduane
Copy link
Author

Forked.

@eeue56 eeue56 closed this as completed May 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants