New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repository names with .
generate invalid JS
#1406
Comments
That would be ambiguous though. |
Ran into a similar problem in my project (https://github.com/zsiciarz/variablestars.net/tree/elm-0.17). The generated JS file contains names like these:
and so on. The actual console error is Here's my elm-package.json. Not sure how to fix this though, perhaps there could be a way to set some sort of alias for the project, so that generated identifiers use that instead of the name of the repo? |
Tracking in #1377, thanks for the report! |
In 0.19 it will not be possible to give packages names like this, thereby avoiding the code gen issues and making package names more uniform across the ecosystem. |
I ran into an issue with the |
@mfeineis It's recommended to leave the repository set to the default There is a bunch of metadata in |
@zwilias Thank your for the clarification, that's exactly what I did :-). As you guessed the result won't be published on |
Given an
elm-package.json
file like the following:Elm generates invalid JavaScript:
In the event of a
.
in a repository name, Elm should convert it to an underscore as it does in other cases of-
in a repository name.The text was updated successfully, but these errors were encountered: