Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search feature for the editor #219

Closed
wants to merge 1 commit into from
Closed

Search feature for the editor #219

wants to merge 1 commit into from

Conversation

lepinay
Copy link
Contributor

@lepinay lepinay commented Dec 29, 2014

No description provided.

@evancz
Copy link
Member

evancz commented Feb 14, 2015

What does this do exactly, I can't tell from the description and code alone.

@lepinay
Copy link
Contributor Author

lepinay commented Feb 14, 2015

It just enables the Ctrl+F search box of code mirror instead of the browser's.
Code mirror search box is a bit more advanced than the browser's one:

  • regex search
  • search and replace

So it is nice to have for small code refactoring.

@evancz
Copy link
Member

evancz commented Jun 12, 2015

This seems nice, but I think I want to keep the online editor dumber than this. I feel like once this is added, people will want to know "how can I get instructions on how to use it well?" And if it's not there at all, no one would expect in in particular. People will maybe feel like "I guess it's time to start using Sublime Text" or whatever.

@evancz evancz closed this Jun 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants