You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 23, 2018. It is now read-only.
For example, assume that in the core package's Basics.elm the line
infixr 0<|
were replaced by
infixl 0<|
At current, elm-package diff would ignore that change. But it should actually be considered a MAJOR change under semantic versioning, because it amounts to changing the type of expressions. For example, a client of core may contain an expression like f <| g <| x. Whether or not this expression is well-typed (given some specific f, g, x) and which type it has (say, if f, g, x are unconstrained and one simply uses type inference) will change between having infixr or infixl for <|. So ignoring that change when computing the diff for core breaks the guarantees expected from semantic versioning in a big way.
The text was updated successfully, but these errors were encountered:
The new implementation checks for that here, so it will count as a major change. The diffs also show the associativity and precedence as well, so you can see the change even though the name and type stays the same.
For example, assume that in the
core
package'sBasics.elm
the linewere replaced by
At current,
elm-package diff
would ignore that change. But it should actually be considered a MAJOR change under semantic versioning, because it amounts to changing the type of expressions. For example, a client ofcore
may contain an expression likef <| g <| x
. Whether or not this expression is well-typed (given some specificf
,g
,x
) and which type it has (say, iff
,g
,x
are unconstrained and one simply uses type inference) will change between havinginfixr
orinfixl
for<|
. So ignoring that change when computing the diff forcore
breaks the guarantees expected from semantic versioning in a big way.The text was updated successfully, but these errors were encountered: