Skip to content
This repository has been archived by the owner on Aug 23, 2018. It is now read-only.

API diff messages print non-Elmy types (instead native implementation shines through) #232

Closed
jvoigtlaender opened this issue Aug 28, 2016 · 2 comments

Comments

@jvoigtlaender
Copy link
Contributor

Using elm-package version 0.17.1.

Added functions

orElseLazy : (() -> Maybe a) -> Maybe a -> Maybe a

orLazy : Maybe a -> (() -> Maybe a) -> Maybe a

to a package.

Ran elm-package diff.

Got this message on the console:

This is a MINOR change.

------ Changes to module Maybe.Extra - MINOR ------

    Added:
        orElseLazy : (_Tuple0 -> Maybe.Maybe a) -> Maybe.Maybe a -> Maybe.Maybe a
        orLazy : Maybe.Maybe a -> (_Tuple0 -> Maybe.Maybe a) -> Maybe.Maybe a

As a user not aware of the internal implementation of tuples I could now be mightily confused about the _Tuple0 mentions.

@process-bot
Copy link

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@evancz
Copy link
Contributor

evancz commented Jul 8, 2017

This should be fixed in 0.19. I am seeing the following behavior:

$ elm diff elm-community/maybe-extra 1.0.0 2.0.0
This is a MAJOR change.

---- Maybe.Extra - MAJOR ----

    Added:
        filter : (a -> Bool) -> Maybe.Maybe a -> Maybe.Maybe a
        orElse : Maybe.Maybe a -> Maybe.Maybe a -> Maybe.Maybe a
        orElseLazy : (() -> Maybe.Maybe a) -> Maybe.Maybe a -> Maybe.Maybe a
        orLazy : Maybe.Maybe a -> (() -> Maybe.Maybe a) -> Maybe.Maybe a
        unpack : (() -> b) -> (a -> b) -> Maybe.Maybe a -> b
        unwrap : b -> (a -> b) -> Maybe.Maybe a -> b
    
    Removed:
        mapDefault : b -> (a -> b) -> Maybe.Maybe a -> b

Thanks for the report!

@evancz evancz closed this as completed Jul 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants