fix(account): set username to undefined on signout #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, that looks like chaos in our build! =) |
|
Sorry for that: Fix due ddda91d Please rebase to avoid merge commits. |
|
NPM test is still pointing to grunt: https://github.com/elmarburke/hoodie-plugin-angularjs/blob/master/package.json#L6 $ npm test
> hoodie-plugin-angularjs@0.0.17 test /Users/djpfahler/localhost/hoodie-plugin-angularjs
> grunt
grunt-cli: The grunt command line interface. (v0.1.13)
Fatal error: Unable to find local grunt.
If you're seeing this message, either a Gruntfile wasn't found or grunt
hasn't been installed locally to your project. For more information about
installing and configuring grunt, please see the Getting Started guide:
http://gruntjs.com/getting-started
npm ERR! Test failed. See above for more details.
npm ERR! not ok code 0
Also $ gulp test
[16:12:39] Using gulpfile ~/localhost/hoodie-plugin-angularjs/Gulpfile.js
[16:12:39] Starting 'karma:dev'...
[16:12:40] Starting Karma server...
INFO [karma]: Karma v0.10.10 server started at http://localhost:9876/
INFO [launcher]: Starting browser PhantomJS
WARN [watcher]: Pattern "/Users/djpfahler/localhost/hoodie-plugin-angularjs/bower_components/jquery/dist/jquery.js" does not match any file.
WARN [watcher]: Pattern "/Users/djpfahler/localhost/hoodie-plugin-angularjs/bower_components/hoodie/dist/hoodie.js" does not match any file.
WARN [watcher]: Pattern "/Users/djpfahler/localhost/hoodie-plugin-angularjs/bower_components/angular/angular.js" does not match any file.
WARN [watcher]: Pattern "/Users/djpfahler/localhost/hoodie-plugin-angularjs/bower_components/angular-mocks/angular-mocks.js" does not match any file.
INFO [PhantomJS 1.9.7 (Mac OS X)]: Connected on socket ZkD97K6qw5Tw6p83asHn
PhantomJS 1.9.7 (Mac OS X) ERROR
ReferenceError: Can't find variable: angular
at /Users/djpfahler/localhost/hoodie-plugin-angularjs/src/_main.js:9
PhantomJS 1.9.7 (Mac OS X) ERROR
ReferenceError: Can't find variable: angular
at /Users/djpfahler/localhost/hoodie-plugin-angularjs/src/hoodieAccount.js:9
PhantomJS 1.9.7 (Mac OS X) ERROR
ReferenceError: Can't find variable: angular
at /Users/djpfahler/localhost/hoodie-plugin-angularjs/src/hoodieArray.js:9
PhantomJS 1.9.7 (Mac OS X) ERROR
ReferenceError: Can't find variable: angular
at /Users/djpfahler/localhost/hoodie-plugin-angularjs/src/hoodieProvider.js:9
PhantomJS 1.9.7 (Mac OS X): Executed 0 of 0 ERROR (0.019 secs / 0 secs)
[16:12:42] 'karma:dev' errored after 2.13 s
[16:12:42] Error in plugin 'gulp-karma'
karma exited with code 1Please fix tests. |
|
Hi @davidpfahler, |
|
The changes are now moved to http://github.com/elmarburke/hoodie-plugin-angularjs/tree/pr/38 and added tests. Currently there is something wrong with the tests, @robinboehm will look at this soon! |
|
@elmarburke You are correct, L26+27 was an oversight on my part. Can I delete my fork or do you need anything else from me? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37.
I was unable to add tests or run the existing tests against this change, so don't merge right away! Neither Grunt nor Gulp ran without errors, I couldn't test. I ran
npm installandbower installand this is the output I get:$ gulp module.js:340 throw err; ^ Error: Cannot find module 'gulp-bump' at Function.Module._resolveFilename (module.js:338:15) at Function.Module._load (module.js:280:25) at Module.require (module.js:364:17) at require (module.js:380:17) at Object.<anonymous> (/Users/djpfahler/localhost/hoodie-plugin-angularjs/Gulpfile.js:7:10) at Module._compile (module.js:456:26) at Object.Module._extensions..js (module.js:474:10) at Module.load (module.js:356:32) at Function.Module._load (module.js:312:12) at Module.require (module.js:364:17) at require (module.js:380:17) at Liftoff.handleArguments (/Users/djpfahler/.nvm/v0.10.29/lib/node_modules/gulp/bin/gulp.js:108:3) at Liftoff.launch (/Users/djpfahler/.nvm/v0.10.29/lib/node_modules/gulp/node_modules/liftoff/index.js:140:6) at Object.<anonymous> (/Users/djpfahler/.nvm/v0.10.29/lib/node_modules/gulp/bin/gulp.js:59:5) at Module._compile (module.js:456:26) at Object.Module._extensions..js (module.js:474:10) at Module.load (module.js:356:32) at Function.Module._load (module.js:312:12) at Function.Module.runMain (module.js:497:10) at startup (node.js:119:16) at node.js:906:3