Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ERROR] Identifier Meteor has already been declared #86

Closed
binlux opened this issue Sep 22, 2018 · 7 comments
Closed

[ERROR] Identifier Meteor has already been declared #86

binlux opened this issue Sep 22, 2018 · 7 comments
Labels

Comments

@binlux
Copy link

binlux commented Sep 22, 2018

using meteor 1.7.0.5

after installing the package it throws this error (Identifier Meteor has already been declared)

@elmarti elmarti added the bug label Sep 23, 2018
@elmarti
Copy link
Owner

elmarti commented Sep 23, 2018

OK, I am able to reproduce this. I believe that this is due the the dependency injection pattern in which Meteor is indirectly referenced. (

this.meteor = meteor;
)

Is it working OK besides the error message? I'll have to look into why it's started logging that error, rather than trying to fix around it.

@elmarti
Copy link
Owner

elmarti commented Sep 23, 2018

I've opened an issue on the Meteor repo meteor/meteor#10234

@aleritty
Copy link

For me no, it isn't working correctly.

It seems to me (but I can be wrong) an incompatibility with latest versions of meteor (1.7.x) because of different babel versions.

Actually if I use the atmosphere package I get this error and the package just doesn't work, but if I use the npm package with include, I get a "syntax error" and after that everything doesn't work (obviously).

To reproduce you can just "meteor update" your demo application (i tried with the blaze one)

@elmarti
Copy link
Owner

elmarti commented Sep 24, 2018

I have reproduced it, there seems to be a strange issue with how the module loading works in 1.7, it appears to be compiling multiple async modules into a single file which are each declared with let, which is what is causing the problem. Going to see if I can fix, but there seems to be a greater issue with the module scoping in packages for this release meteor/meteor#10234

@binlux
Copy link
Author

binlux commented Sep 24, 2018

Is it working OK besides the error message?

when installing the package(just installing without using it) my app works in dev mode but in production mode it fails

just i want you to know that the last compatible version of (@babel/runtime) with meteor 1.7.0.x is 7.0.0-beta.55 maybe it's a babel issue as @aleritty says...but you can try the beta of meteor 1.7.1 it's compatible with tha last version of (@babel/runtime) and check if it's working

@elmarti
Copy link
Owner

elmarti commented Sep 24, 2018

@jamalCoder I've just posted a fix meteor-video-chat@2.3.1, it's definitely related to the bundling

@elmarti
Copy link
Owner

elmarti commented Sep 26, 2018

This has now been confirmed as a Meteor core bundling bug that will be fixed in 1.8. This package should still work with this fix and will stay the same unless any unseen issues arise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants