Add Mime() to exclude parameters in generated string #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a Mime() method on the ContentType to be able to get the MIME only part without the parameters for simpler comparison against other MIME-types in for example switch statements.
GitOpsBot
reviewed
May 9, 2022
There was a problem hiding this comment.
GoGitOps Review
Grade: A+ (94.1%)
Files: 2
Issues: 1
gofmt: 100%
go_vet: 100%
golint: 100%
gocyclo: 50%
contenttype.go
Line 379: warning: cyclomatic complexity 24 of function GetAcceptableMediaTypeFromHeader() is high (> 15) (gocyclo)
contenttype.go
Line 52: warning: cyclomatic complexity 17 of function isTokenChar() is high (> 15) (gocyclo)
license: 100%
ineffassign: 100%
misspell: 100%
This report was generated using GoGitOps.
elnormous
reviewed
May 9, 2022
contenttype.go
Outdated
| @@ -300,6 +300,19 @@ func (mediaType *MediaType) String() string { | |||
| return stringBuilder.String() | |||
| } | |||
|
|
|||
| // Mime returns the MIME type without any of the parameters | |||
| func (mediaType MediaType) Mime() string { | |||
There was a problem hiding this comment.
Golang naming convention states that acronyms must be capitalized (for example https://pkg.go.dev/net/http#ParseHTTPVersion) so this should be named MIME.
Go conventions speify abbreviations are to be kept uppercase.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Mime() method on the ContentType to be able to get the MIME only
part without the parameters for simpler comparison against other
MIME-types in for example switch statements.
Partially closes #3