Added support for timestamps. #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 11, 2015 00:41
| testID string | ||
| status string | ||
| // Event is a status or a file attachment event. | ||
| type Event struct { |
There was a problem hiding this comment.
IMO it would be better if the production code is not aware of the tests, if it doesn't have different execution paths for the different environments. Maybe an interface here could be useful, with different implementations for production and for testing, what do you think?
There was a problem hiding this comment.
Scratch that, I misunderstood that this TestId is about the "client" test, not the package ones
come-maiz
added a commit
that referenced
this pull request
Sep 11, 2015
Added support for timestamps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.