Skip to content
This repository has been archived by the owner on Jul 8, 2023. It is now read-only.

PHPUnit 7 support #1

Closed
ezzatron opened this issue Jan 23, 2018 · 6 comments
Closed

PHPUnit 7 support #1

ezzatron opened this issue Jan 23, 2018 · 6 comments

Comments

@ezzatron
Copy link
Contributor

Releases ~ Feb 2.

@enumag
Copy link

enumag commented Mar 5, 2018

Can I help with something to solve this?

@ezzatron
Copy link
Contributor Author

ezzatron commented Mar 5, 2018

The bulk of work here is already done over at eloquent/phony#php71-minimum. Since PHPUnit 7 no longer supports PHP 7.0, I'm working on a new major version of Phony's core that does the same.

PHP 7.1 lets me take advantage of nullable and void types, so it will improve some interfaces, and allow me to throw out a bunch of conditional code for supporting PHP 7.0.

Here's what's left to do before I can roll out this feature:

  1. Documentation updates, including any API and usage example changes.
  2. Making a branch of phony-phpunit that uses phony@php71-minimum, updating the APIs to match upstream changes, updating CI configs, etc. etc.
  3. Addressing any problems found by integrating the 2 repos in step 2.
  4. Ideally, trying out the changes on some real-world test suites.
  5. Releasing - change logs, tagging, waiting for builds, rinse, repeat.

Sorry it's taking a while, I've just been especially busy with real-world work, moving house etc. I will try to push this out over the next week or so. In the mean time, I opened a PR for the core changes so that they're open for discussion: eloquent/phony#235

@ezzatron
Copy link
Contributor Author

FYI, there's now a preview branch for this if you need it.

@ezzatron
Copy link
Contributor Author

@enumag This is in master now, and I have a 4.0.x-dev branch alias set up, so you should be able to try it out with an "eloquent/phony-phpunit": "^4" constraint.

At least, I think so. I haven't used branch aliases much 😅

@enumag
Copy link

enumag commented Mar 13, 2018

@ezzatron I just tried. it works just fine, good job!

@ezzatron
Copy link
Contributor Author

Released in 4.0.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants