Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTHERS] Multiple ISOs released at one time #116

Closed
elreydetoda opened this issue Oct 10, 2021 · 0 comments · Fixed by #121
Closed

[OTHERS] Multiple ISOs released at one time #116

elreydetoda opened this issue Oct 10, 2021 · 0 comments · Fixed by #121
Assignees
Labels
bug Something isn't working others a bug that is caused by another company
Milestone

Comments

@elreydetoda
Copy link
Owner

elreydetoda commented Oct 10, 2021

Vendor
Offsec/Kali

Describe the issue/link to bug reported to vendor
Apparently there has been a new ISO created for the 2021.3, so now it is at 2021.3a. Don't have a process for selecting the higher semver version for that.

image

here is some of the output from a debug run of the scripts/new-kali.sh script which was failing ( run1 & run2 )

+ printf %s '{"vm_name":"elrey741/kali-linux_amd64","iso_url":"https://cdimage.kali.org/current/kali-linux-2021.3-installer-netinst-amd64.iso
kali-linux-2021.3a-installer-netinst-amd64.iso","iso_checksum":"e06c26b2de306b1f4c12d015daf0b8e72b19672ee26ee2a5f2b86b828477dc1d

as you can see, there is a reference to 2 different isos versions, separated by a newline. I believe this was what caused the encoding error with printf in the CI runs.

parse error: Invalid string: control characters from U+0000 through U+001F must be escaped at line 2, column 47

Additional context
Need to have it choose the highest semver version.

@elreydetoda elreydetoda added bug Something isn't working others a bug that is caused by another company labels Oct 10, 2021
@elreydetoda elreydetoda added this to the Others Bugs milestone Oct 10, 2021
@elreydetoda elreydetoda self-assigned this Oct 10, 2021
@elreydetoda elreydetoda added this to To do in Roadmap via automation Oct 10, 2021
This was referenced Oct 10, 2021
Roadmap automation moved this from To do to Done Oct 10, 2021
@elreydetoda elreydetoda linked a pull request Oct 10, 2021 that will close this issue
@elreydetoda elreydetoda removed this from Done in Roadmap Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working others a bug that is caused by another company
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant