bookmarkFinder.FindBookmarksAsync<Activity>(correlationId) returns all of that type

[matt4446]

Finding bookmarks by correlation id doesn't seem to filter by correlation id;
correlationId : Bookmarks-2021-10-05 15:48:34Z

var all = await bookmarkFinder.FindBookmarksAsync<Activities.RunCodeActivity>(correlationId: correlationId);

The two records above being two different correlations roughly ~2 mins from each other where I should only be expecting the latter.

Speaking of bookmarks...
They never seem to go into the yessql store. Is there an option to persist them that I've missed?

And they all disappear when the app restarts

[sfmskywalker]

Different but related issue. Before my fix, the in-memory provider was used for Bookmark storage but now the YesSQL one is used. Looks like you found a query that is not properly mapped. If you can show me the full stack trace I might see what code is setting up the OR specification.

[matt4446]

beginning at:

10/07/2021 12:20:30 +01:00 Unhandled exception rendering component: "An expression of non-boolean type specified in a context where a condition is expected, near 'or'."
Microsoft.Data.SqlClient.SqlException (0x80131904): An expression of non-boolean type specified in a context where a condition is expected, near 'or'.
   at Microsoft.Data.SqlClient.SqlCommand.<>c.<ExecuteDbDataReaderAsync>b__203_0(Task`1 result)
   at System.Threading.Tasks.ContinuationResultTaskFromResultTask`2.InnerInvoke()
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
--- End of stack trace from previous location ---
   at Dapper.SqlMapper.QueryAsync[T](IDbConnection cnn, Type effectiveType, CommandDefinition command) in /_/Dapper/SqlMapper.Async.cs:line 418
   at YesSql.Store.ProduceAsync[T,TState](WorkerQueryKey key, Func`2 work, TState state)
   at YesSql.Services.DefaultQuery.Query`1.ListImpl()
   at YesSql.Services.DefaultQuery.Query`1.ListImpl()
   at Elsa.Persistence.YesSql.Stores.YesSqlStore`2.FindManyAsync(ISpecification`1 specification, IOrderBy`1 orderBy, IPaging paging, CancellationToken cancellationToken)
   at Elsa.Persistence.YesSql.Stores.YesSqlStore`2.FindManyAsync(ISpecification`1 specification, IOrderBy`1 orderBy, IPaging paging, CancellationToken cancellationToken)
   at Elsa.Services.Bookmarks.BookmarkFinder.FindBookmarksAsync(String activityType, IEnumerable`1 bookmarks, String correlationId, String tenantId, CancellationToken cancellationToken)

[sfmskywalker]

I can't seem to reproduce this issue from here. Can you send me a (stripped down) version of your project I can look at?

[matt4446]

Yep, creating one now while working on other bugs

[matt4446]

Version: 2.4.0-preview.302
https://github.com/matt4446/ElsaQuickstarts.Server.DashboardAndServer2

I didn't come across the above error ("An expression of non-boolean type specified in a context where a condition is expected, near 'or'.") on a new project with yessql+sqllite so will look at my more complicated version more closely. Finding bookmarks with both these worked:
var currentBookmarks = (await approveInputDispatcher.FindRequiredInputs()).ToList();
var currentWithCorrelationId = (await approveInputDispatcher.FindRequiredInputs(first.CorrelationId)).ToList();

However, this function isn't returning anything in the test project above.:

https://github.com/matt4446/ElsaQuickstarts.Server.DashboardAndServer2/blob/ef9cebf23d1b04e873e329572de04e02edc9fc2e/ElsaQuickstarts.Server.DashboardAndServer2/Services/ApproveInputDispatcher.cs#L39

It returns 0 (IEnumerable) records, if you can spot anything wrong with it? I tried a few combinations with no success

[matt4446]

The example above sets the workflow into action itself

Producing new work every 30 seconds
And finding that work every 10 seconds with the bookmarks to potentially approve them.

[matt4446]

"An expression of non-boolean type specified in a context where a condition is expected, near 'or'." still occurs in my main project. More digging to do (same 302 version)
:)

[matt4446]

Its failed sql

exec sp_executesql N'SELECT DISTINCT [Elsa2_Bookmarks_Document].* FROM [Elsa2_Bookmarks_Document] INNER JOIN [Elsa2_Bookmarks_BookmarkIndex] AS [BookmarkIndex_a1] ON [BookmarkIndex_a1].[DocumentId] = [Elsa2_Bookmarks_Document].[Id] WHERE ((([BookmarkIndex_a1].[TenantId] IS NULL) and ([BookmarkIndex_a1].[ActivityType] = @p0)) and (@p1 or ([BookmarkIndex_a1].[CorrelationId] = @p2)))',N'@p0 nvarchar(4000),@p1 bit,@p2 nvarchar(4000)',@p0=N'RunCodeActivity',@p1=0,@p2=N'Bookmarks-2021-10-06 08:15:35Z'

Messages:

Msg 4145, Level 15, State 1, Line 1
An expression of non-boolean type specified in a context where a condition is expected, near 'or'.

Completion time: 2021-10-08T16:50:38.1811600+01:00

[matt4446]

And im missing the CorrelationId field. Might be because this DB was created in the alpha days.

@p1 being the problem by the looks of it.
(@p1 or ([BookmarkIndex_a1].[CorrelationId] = @p2))

[sfmskywalker]

It returns 0 (IEnumerable) records, if you can spot anything wrong with it? I tried a few combinations with no success

It seems to work correctly when I try:

And im missing the CorrelationId field. Might be because this DB was created in the alpha days.

Yes that would indeed be an issue. You should be able to add it manually.

[matt4446]

The later problem was with the collect and execute 😁.

The bookmarking part seems to be functioning ok in the demo project.

[matt4446]

It would appear the following could be causing the bad SQL from Elsa.Persistence.Specifications.Bookmarks.BookmarkSpecification

(Expression<Func<Bookmark, bool>>) 
(bookmark => bookmark.TenantId == this.TenantId 
	&& bookmark.ActivityType == this.ActivityType 
	&& (
		this.CorrelationId == default (string) || bookmark.CorrelationId == this.CorrelationId)
);

It would appear this part is evaluating
(this.CorrelationId == default (string) || bookmark.CorrelationId == this.CorrelationId)
to 0 OR CorrelaitionId = "create farm...."

With the exception:
10/07/2021 12:20:30 +01:00 Unhandled exception rendering component: "An expression of non-boolean type specified in a context where a condition is expected, near 'or'."

SELECT DISTINCT [Elsa2_Bookmarks_Document].* FROM [Elsa2_Bookmarks_Document] INNER JOIN [Elsa2_Bookmarks_BookmarkIndex] AS [BookmarkIndex_a1] ON [BookmarkIndex_a1].[DocumentId] = [Elsa2_Bookmarks_Document].[Id] WHERE ((([BookmarkIndex_a1].[TenantId] IS NULL) and ([BookmarkIndex_a1].[ActivityType] = @p0)) and (@p1 or ([BookmarkIndex_a1].[CorrelationId] IS NULL)))

Now to check the test project

[matt4446]

Interesting. The test project gets to the same place with

(Expression<Func<Bookmark, bool>>) (bookmark => bookmark.TenantId == this.TenantId && bookmark.ActivityType == this.ActivityType && (this.CorrelationId == default (string) || bookmark.CorrelationId == this.CorrelationId));

Something YesSql is doing differently I wonder.

[matt4446]

I've updated the git repository to reproduce the problem. It required SQL Server 😂

SQL and parameters were equal between both SqlLite and SqlServer on both my projects (test and master).
It fails with "An expression of non-boolean type specified in a context where a condition is expected, near 'or'." on SQL Server but the same is fine on SqlLite using the YesSql providers.

We could create a better Expression<> from

(Expression<Func<Bookmark, bool>>) (bookmark => bookmark.TenantId == this.TenantId && bookmark.ActivityType == this.ActivityType && ( this.CorrelationId == default (string) || bookmark.CorrelationId == this.CorrelationId) );

bookmark.CorrelationId == this.CorrelationId should only be present if this.CorrelationId is null or empty.

[sfmskywalker]

Makes sense. Do you want to send a PR?

[matt4446]

Possibly, which direction would you prefer? Its been a while since I've used linqkit

public override Expression<Func<Bookmark, bool>> ToExpression() =>
            CorrelationId == null
            ? bookmark => bookmark.TenantId == TenantId
                && bookmark.ActivityType == ActivityType
            : bookmark => bookmark.TenantId == TenantId
                && bookmark.ActivityType == ActivityType
                && bookmark.CorrelationId == CorrelationId;

public Expression<Func<Bookmark, bool>> ToExpression() {
            LinqKit.ExpressionStarter<Bookmark>? expressionBuilder = LinqKit.PredicateBuilder.New<Bookmark>();

            expressionBuilder = expressionBuilder.And(bookmark => bookmark.TenantId == TenantId);
            expressionBuilder = expressionBuilder.And(bookmark => bookmark.ActivityType == ActivityType);

            if (this.CorrelationId != null) 
            {
                expressionBuilder = expressionBuilder.And(bookmark => bookmark.CorrelationId == CorrelationId);
            }

            return expressionBuilder;
        }

[sfmskywalker]

Let's stick with your first suggestion - seems simpler if you agree?

[matt4446]

It was certainly the quickest to write but not as much fun as playing with linqkit

[sfmskywalker]

Well I certainly wouldn’t want to bereft you of your fun :D

Feel free to use linqkit - it may prove useful in other areas as well.