Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a Kafka activity is causing duplicated WorkFlowTrigger instance #3832

Closed
dao74 opened this issue Mar 24, 2023 · 5 comments
Closed

Using a Kafka activity is causing duplicated WorkFlowTrigger instance #3832

dao74 opened this issue Mar 24, 2023 · 5 comments

Comments

@dao74
Copy link

dao74 commented Mar 24, 2023

I have added a Kafka activity into a flow and saw that the flow is running twice.

Checking of the Triggers table: the records related to the Kafka activity were duplicated.

After debug I found out the duplication was caused in the Elsa.Services.Triggers.TriggersForActivityBlueprintAndWorkflowProvider. **GetTriggersForActivityBlueprintAsync** method.

supportedBookmarkProviders =
Elsa.Activities.Kafka.Bookmarks.OverrideKafkaBookmarkProvider,
Elsa.Activities.Kafka.Bookmarks.QueueMessageReceivedBookmarkProvider

GetTriggersForBookmarkProvider is returning 2 items WorkflowTrigger with identical values (ActivityType=KafkaMessageReceived)

Please check and advise.

@sfmskywalker
Copy link
Member

@Snotax Maybe you experienced this as well?

@Snotax
Copy link

Snotax commented Mar 24, 2023

@sfmskywalker I will check on monday, but from memory I don't think that my workflows got triggered multiple times.

@sfmskywalker
Copy link
Member

Perfect, thank you!

@sfmskywalker
Copy link
Member

@dao74 This should be fixed now with the preview build (https://github.com/elsa-workflows/elsa-core/actions/runs/4530401599) with to the PR from @Snotax

@dao74
Copy link
Author

dao74 commented Mar 27, 2023

Seems working, thank you.

@dao74 dao74 closed this as completed Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants