Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dapper DeleteAsync #4676

Closed
ghost opened this issue Dec 4, 2023 · 2 comments
Closed

Dapper DeleteAsync #4676

ghost opened this issue Dec 4, 2023 · 2 comments
Assignees
@sfmskywalker
Milestone
Elsa 3.1

Comments

@ghost
Copy link

ghost commented Dec 4, 2023

I think there is a bug in the DeleteAsync method.

Here, when creating the query, it uses a fixed string ("rowid") as the primary key insted of the PromaryKey property.
@sfmskywalker sfmskywalker self-assigned this Jan 6, 2024
@sfmskywalker
Copy link
Member

Nice catch - the "rowid" field is specific to SQLite. I will update this 👍🏻

@sfmskywalker sfmskywalker added this to the Elsa 3.1 milestone Jan 6, 2024
@sfmskywalker
Copy link
Member

Fixed via 6268fe474153fd1df0f9ebdda0e9475872b6ec2c

@sfmskywalker sfmskywalker changed the title Elsa V3 - Dapper DeleteAsync Dapper DeleteAsync Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfmskywalker sfmskywalker

Labels
None yet
Projects
ELSA 3
Status: Done
Milestone
Elsa 3.1
Development

No branches or pull requests
1 participant
@sfmskywalker