Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expired messages in Workflow Inbox should be ignored #5549

Closed
martinmanfar opened this issue Jun 7, 2024 · 2 comments
Closed

Expired messages in Workflow Inbox should be ignored #5549

martinmanfar opened this issue Jun 7, 2024 · 2 comments
Labels
bug Something isn't working elsa 3 This issue is specific to Elsa 3
Milestone

Comments

@martinmanfar
Copy link

Description

When a bookmark is created the library tries to find existing messages in the Workflow Inbox but it should exclude expired ones.

Steps to Reproduce

  1. Publish an event in the Workflow Inbox.
  2. Wait until that event is expired (by default 1 min).
  3. Start a workflow with the Event activity that waits for the same event.
  4. The activity bookmark matches with the previous expired event.

Expected Behavior

The activity was suspended waiting for a new event because the existing one is expired.

Actual Behavior

The activity was resumed because it used the expired event.

Environment

ELSA 3.2

@martinmanfar martinmanfar added the bug Something isn't working label Jun 7, 2024
@sfmskywalker sfmskywalker added the elsa 3 This issue is specific to Elsa 3 label Jun 7, 2024
@sfmskywalker sfmskywalker modified the milestones: Elsa 3.2, Elsa 3.3 Jun 7, 2024
@elsa-workflows elsa-workflows deleted a comment from glime-ai bot Jun 7, 2024
@sfmskywalker
Copy link
Member

Thank you for reporting this issue. Your findings are correct, the issue is similar to what has been reported via #5203 and #5409

The WorkflowInbox API is being deprecated as of the future 3.3 release and its implementation will have been updated to use the new Stimulus API, which does not suffer from the reported issues.

@sfmskywalker
Copy link
Member

Closed via #5444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working elsa 3 This issue is specific to Elsa 3
Projects
Status: Done
Development

No branches or pull requests

2 participants