-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove console.log in src/ #3
Comments
The |
@derhuerst That could be good! I am not sure yet which of these messages the caller might care about or want to work with programmatically, and which of these messages are, "everything is working fine, FYI!" |
Theoretically, all the messages that a caller is interested in should be available via returns values, events, or something similar. Console logging a very unintuitive and also inflexible way of getting messages, but certainly necessary in debugging. That's why I propose |
Sounds good to me. If someone ends up needing a value or event, we can always pass it up as an event later. As an initial step, I may just go through and comment out all of the |
I commented out all the I think I will close this issue for now. If callers end up needing these messages, we can use |
There are a few places where we
console.log
informative messages, resulting in a console with messages like:I think each of these messages should get emitted over some
emitter
returned by the highest-level entity that makes sense (sessionCipher
s come to mind).The text was updated successfully, but these errors were encountered: