Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test methods for adds, query, update, delete #17

Closed
5 tasks done
euledge opened this issue Sep 8, 2023 · 2 comments · Fixed by #18
Closed
5 tasks done

add test methods for adds, query, update, delete #17

euledge opened this issue Sep 8, 2023 · 2 comments · Fixed by #18

Comments

@euledge
Copy link
Contributor

euledge commented Sep 8, 2023

Details of Improvement

  • I want to adds test method (Add, Query, Update, Delete).

Reference Issue

#9

Expected behavior

implements tests below

  • Adds Collection Items
  • Get Collection Item
  • Query Collection Items
  • Update Collection Item
  • Delete Collection Item
@euledge euledge mentioned this issue Sep 8, 2023
Merged
5 tasks
@euledge
Copy link
Contributor Author

euledge commented Sep 8, 2023

ミスっていたところ

  • idの重複登録
  • awaitの漏れ

ですね。review&fix ありがとうございます。

@KishiTheMechanic
Copy link
Collaborator

はい、そんな感じでした！
あとはissueも上げていただいたところなんですが今のところfirestoreのqueryに制限があるようでした！(レンジ使うと2種類以上のfieldで並び替えできない)

こちらこそいつもありがとうございます！

引き続きよろしくお願いいたします🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add tests for add, query, update, delete euledge/skeet-firestore
2 participants
@euledge @KishiTheMechanic