Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weather extension displaying "<Location>," #10

Closed
GoogleCodeExporter opened this issue May 10, 2015 · 12 comments
Closed

Weather extension displaying "<Location>," #10

GoogleCodeExporter opened this issue May 10, 2015 · 12 comments

Comments

@GoogleCodeExporter
Copy link

What is the expected output? What do you see instead?

The appended text or no comma.

What version of the product are you using?

Play Store current

Which device and Android version are you experiencing this issue on?

Nexus 4, CM10.1 latest nightly at time of posting.

Original issue reported on code.google.com by ldjugg...@gmail.com on 12 Feb 2013 at 10:15

@GoogleCodeExporter
Copy link
Author

Oh, very interesting. Can you take a screenshot and post it here? Might be a 
parser bug.

Original comment by roman.nurik on 12 Feb 2013 at 12:02

@GoogleCodeExporter
Copy link
Author

Here's a screenshot of the problem. I'm also on N4 using CM10.1 nightly (latest)

Original comment by kris.nielsen1 on 12 Feb 2013 at 12:09

Attachments:

@GoogleCodeExporter
Copy link
Author

Alright, thanks!

Original comment by roman.nurik on 12 Feb 2013 at 12:11

@GoogleCodeExporter
Copy link
Author

@kris I was just about to add mine, cheers :) 

Original comment by ldjugg...@gmail.com on 12 Feb 2013 at 12:11

@GoogleCodeExporter
Copy link
Author

https://code.google.com/p/dashclock/source/browse/main/src/com/google/android/ap
ps/dashclock/weather/WeatherExtension.java#267

and 269. 

I'd check in a fix if I wasn't at work :P

Original comment by ldjugg...@gmail.com on 12 Feb 2013 at 12:37

@GoogleCodeExporter
Copy link
Author

Oh, so the region is empty. That's pretty odd. Will see if there's other 
information I can use instead. Maybe "<Location>, <Country>" if region is 
missing.

Original comment by roman.nurik on 12 Feb 2013 at 1:20

@GoogleCodeExporter
Copy link
Author

Country seems right, I'm from the UK - most location look-ups don't provide a 
region/county here.

Original comment by ldjugg...@gmail.com on 12 Feb 2013 at 1:23

@GoogleCodeExporter
Copy link
Author

Original comment by roman.nurik on 12 Feb 2013 at 9:09

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

This issue was closed by revision 27ca50ee16e9.

Original comment by roman.nurik on 13 Feb 2013 at 4:03

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Will be fixed in version 1.1.

Original comment by roman.nurik on 13 Feb 2013 at 4:04

@GoogleCodeExporter
Copy link
Author

Original comment by roman.nurik on 13 Feb 2013 at 4:07

  • Added labels: TargetRelease-1.1

@GoogleCodeExporter
Copy link
Author

Original comment by roman.nurik on 17 Feb 2013 at 6:48

  • Changed state: Released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant