Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMagic dependency #20

Closed
y8 opened this issue Oct 10, 2014 · 6 comments
Closed

RMagic dependency #20

y8 opened this issue Oct 10, 2014 · 6 comments

Comments

@y8
Copy link

y8 commented Oct 10, 2014

Hi.

Why is carrierwave-vips depends on RMagic? If this is not necessary, could you please remove it from gemspec?

Thanks

@eltiare
Copy link
Owner

eltiare commented Oct 11, 2014

It's a dependency of vips, so it is a dependency of carrierwave-vips. If you wish to continue this conversation I'd suggest opening a ticket on that repo.

@eltiare eltiare closed this as completed Oct 11, 2014
@y8
Copy link
Author

y8 commented Oct 11, 2014

Um, sorry but RMagick can't possibly be a vips library dependency since RMagick a ruby fronted for ImageMagick and GraphicMagick. It has nothing to do with vips, because vips is not a ruby library.

Also, you are using ruby-vips interface, and it's their responsibility to maintain dependencies. But anyway, there no RMagick dependency in ruby-vips, and you can use it without building Rmagick.

@y8
Copy link
Author

y8 commented Oct 11, 2014

@eltiare
Copy link
Owner

eltiare commented Oct 11, 2014

Oh, you're right. Sorry about that - been a while since I've dug into the internals of all of this. One of the perils of having something work for a long time. I'll look into it, I think it had something to do with loading GIF files. Perhaps I'll strip out the requirement and then add a note to the README that to load the gif files rmagick is required.

@eltiare eltiare reopened this Oct 11, 2014
@tonytonyjan
Copy link

FYI #21

@eltiare
Copy link
Owner

eltiare commented Sep 7, 2016

Fixed in master.

@eltiare eltiare closed this as completed Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants