Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insert + rollup-plugin-node-resolve v5 did not work #64

Closed
bobaaaaa opened this issue May 16, 2019 · 2 comments
Closed

insert + rollup-plugin-node-resolve v5 did not work #64

bobaaaaa opened this issue May 16, 2019 · 2 comments

Comments

@bobaaaaa
Copy link

A rollup config with sass + rollup-plugin-node-resolve@5 and the option insert: true did not work properly. See Changelog.

What I can see:

  • the global ___$insertStyle function is generated correctly in the bundle
  • the actual call of the ___$insertStyle function including the styles is not generated

Here are my rollup.config.js:

{
    input: './src/foo.ts',
    output: [
        { file: 'dist/foo.js', format: 'es' }
    ],
    external: ['bar'],
    plugins: [
        resolve(),
        typescript(),
        sass({
            output: false,
            insert: true
        })
    ]
}

Workaround:
Remove rollup-plugin-node-resolve
or
Use rollup-plugin-node-resolve@4.2.4 (latest v4)

@differui
Copy link
Collaborator

differui commented May 17, 2019

rollup-plugin-sass.test.zip

Hi @bobaaaaa :

I created a simple codebase according to your description but fail to reproduce the bug.
Can you give it a look and help to reproduce?

@bobaaaaa
Copy link
Author

Hi @differui you're right. I can not reproduce my problem with a clean/new project. It seems to be a problem with our strange project setup/build (yarn + monorepo + typescript. I close the issue. Sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants