Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional string resources to the Pipeline Editor Canvas #797

Merged
merged 1 commit into from Aug 1, 2020

Conversation

lresende
Copy link
Member

@lresende lresende commented Aug 1, 2020

There were new string resources introduced to Elyra 0.9.x

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Elyra Canvas 9.x introduced new string resources, and it is
producing multiple warnings on the browser console as these
are not defined in the Pipeline Editor project.
@lresende lresende added the component:pipeline-editor pipeline editor label Aug 1, 2020
@lresende lresende added this to the 1.0.0 milestone Aug 1, 2020
Copy link
Member

@ajbozarth ajbozarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you just grabbed this from the canvas repo?

@lresende
Copy link
Member Author

lresende commented Aug 1, 2020

Yes

@lresende lresende merged commit 4e9f13b into elyra-ai:master Aug 1, 2020
@lresende lresende deleted the update-canvas-intl-json branch August 1, 2020 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants