Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attributes ignore minimum due to skill rating #630

Closed
elyukai opened this issue Jul 3, 2020 · 0 comments · Fixed by #678
Closed

Attributes ignore minimum due to skill rating #630

elyukai opened this issue Jul 3, 2020 · 0 comments · Fixed by #678
Assignees
Labels
Bug A bug Effort: Moderate Seems to be resolvable High Priority Must be handled for the next update ASAP
Milestone

Comments

@elyukai
Copy link
Owner

elyukai commented Jul 3, 2020

The Skill Rating maximum is the highest check attribute + 2. So if those levels are reached, it must be ensured the highest attribute cannot be lowered – but thats not the case currently.

There are several options I can think of that would solve the problem – but I'm not sure what would be the most efficient and practical way, especially for advanced heroes.

  1. Create a selector for the attributes tab that iterates through every available skill and returns the minimum value for each attribute.
  2. Create a dependency for every skill and update on each skill rating change.
  3. Create a selector for the attributes tab for each attribute and iterate through every available skill to find any skills that affect the respective attribute.
@elyukai elyukai added Bug A bug High Priority Must be handled for the next update ASAP Effort: Moderate Seems to be resolvable Needs Investigation Requires investigating the source of the issue labels Jul 3, 2020
@elyukai elyukai added this to the 1.3.3 milestone Jul 3, 2020
@elyukai elyukai added this to Backlog in v1.3.x via automation Jul 3, 2020
@elyukai elyukai added this to Backlog in v1.5.x via automation Aug 5, 2020
@elyukai elyukai moved this from Backlog to Active in v1.5.x Aug 22, 2020
@elyukai elyukai self-assigned this Aug 22, 2020
@elyukai elyukai removed the Needs Investigation Requires investigating the source of the issue label Aug 22, 2020
@elyukai elyukai closed this as completed Sep 9, 2020
v1.5.x automation moved this from Active to Done, not released Sep 9, 2020
@elyukai elyukai moved this from Done, not released to Done in v1.5.x Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug Effort: Moderate Seems to be resolvable High Priority Must be handled for the next update ASAP
Projects
No open projects
v1.3.x
Backlog
v1.5.x
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant