Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item category references differ from folder names #30

Open
plu2k opened this issue Dec 18, 2023 · 0 comments
Open

Item category references differ from folder names #30

plu2k opened this issue Dec 18, 2023 · 0 comments

Comments

@plu2k
Copy link
Contributor

plu2k commented Dec 18, 2023

Item categories references are in singular and use and as conjunction, whereas folder names are held in plural als use or as conjunction, e. g. "BandagesAndRemedies" vs "BandageOrRemedy".

This is somewhat inconvenient because the ItemsIdMap (for compatibility) uses folder names, and one needs a lookup table to map the new item reference from e. g.
- [ITEMTPL_143, BandagesAndRemedies, 5]
to the category BandageOrRemedy to create a valid item reference. Such a mapping is nowhere in the code and has to be created manually.

Proposal: Change folder names to item category names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant