Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the tests for elsa-make-type comparing to vectors with comparing to print representation #40

Closed
Fuco1 opened this issue Aug 10, 2018 · 0 comments
Labels

Comments

@Fuco1
Copy link
Member

Fuco1 commented Aug 10, 2018

Because different versions of emacs use different representation of objects (vectors before 26 and records after 26) half the tests fails.

We can kill two birds with one stone by testing that whatever type the macro produces serializes back to the form that created it, such that reading it back would produce the same type.

However, we need to take into account normalization of nested parens, such that (Int) and Int are equivalent even though the form is different (both will print as Int)

This was discovered in #20.

@Fuco1 Fuco1 added the bug label Aug 10, 2018
@Fuco1 Fuco1 closed this as completed in b290871 Aug 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant