Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation warnings #506

Closed
lionel- opened this issue Mar 17, 2018 · 2 comments
Closed

Fix compilation warnings #506

lionel- opened this issue Mar 17, 2018 · 2 comments
Assignees
@jabranham
Labels
infra
Milestone
Future

Comments

@lionel-
Copy link
Member

lionel- commented Mar 17, 2018

No description provided.

@lionel- lionel- added the infra label Mar 17, 2018
@jabranham jabranham mentioned this issue Apr 11, 2018
Merged
@jabranham jabranham mentioned this issue Jul 24, 2018
Merged
@jabranham
Copy link
Contributor

When we do eventually fix this, it would be nice to set byte-compile-error-on-warn to t on our CI service to catch warnings we might introduce.

@jabranham jabranham self-assigned this Sep 13, 2018
@jabranham jabranham added this to the 19.04 milestone Sep 13, 2018
@jabranham jabranham mentioned this issue Oct 20, 2018
Merged
@jabranham
Copy link
Contributor

Closing this as the next branch should byte compile on the most recent Emacs major release without warnings. Travis now errors on warnings with Emacs 26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jabranham jabranham

Labels
infra
Projects
None yet
Milestone
Future
Development

No branches or pull requests
2 participants
@lionel- @jabranham